Fix -Wmaybe-uninitialized with GCC 16 in CHOOSE_IMPLEMENTATION macros#966
Merged
daxhuiberts merged 2 commits intomainfrom May 6, 2026
Merged
Fix -Wmaybe-uninitialized with GCC 16 in CHOOSE_IMPLEMENTATION macros#966daxhuiberts merged 2 commits intomainfrom
daxhuiberts merged 2 commits intomainfrom
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
==========================================
+ Coverage 96.71% 96.92% +0.21%
==========================================
Files 129 130 +1
Lines 8057 7749 -308
==========================================
- Hits 7792 7511 -281
+ Misses 265 238 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
May 6, 2026
Itzikvaknin
approved these changes
May 6, 2026
GCC 16 improved its uninitialized variable analysis and now warns that `__ret_dist_func` may be used uninitialized: the switch is exhaustive (e.g. `CASES16` covers exactly 0-15 and `dim % 16` can only produce 0-15), but GCC cannot prove this from the recursive macro expansion. Add `default: __builtin_unreachable()` to both `CHOOSE_IMPLEMENTATION` and `CHOOSE_SVE_IMPLEMENTATION` to explicitly signal to the compiler that no other case is reachable, allowing it to conclude the variable is always initialized before use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 16 improved its uninitialized variable analysis and now warns that
__ret_dist_funcmay be used uninitialized: the switch is exhaustive (e.g.CASES16covers exactly 0-15 anddim % 16can only produce 0-15), but GCC cannot prove this from the recursive macro expansion.Add
default: __builtin_unreachable()to bothCHOOSE_IMPLEMENTATIONandCHOOSE_SVE_IMPLEMENTATIONto explicitly signal to the compiler that no other case is reachable, allowing it to conclude the variable is always initialized before use.Note
Low Risk
Low risk: this is a compile-time hint to silence GCC 16
-Wmaybe-uninitializedwarnings, with no intended runtime behavior change. The main risk is undefined behavior if the switch becomes non-exhaustive in the future and hits__builtin_unreachable().Overview
Fixes new GCC 16
-Wmaybe-uninitializedwarnings inimplementation_chooser.hby making the switch statements inCHOOSE_IMPLEMENTATIONandCHOOSE_SVE_IMPLEMENTATIONexplicitly exhaustive.Adds
default: __builtin_unreachable()so the compiler can prove__ret_dist_funcis always initialized before assignment, without changing the selected implementation for valid inputs.Reviewed by Cursor Bugbot for commit 17073f7. Bugbot is set up for automated code reviews on this repo. Configure here.