-
Notifications
You must be signed in to change notification settings - Fork 106
Add Keras model test with TF2 model #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hhsecond you might want to add this use case to your export library |
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
======================================
Coverage 57.1% 57.1%
======================================
Files 26 26
Lines 5133 5133
======================================
Hits 2931 2931
Misses 2202 2202Continue to review full report at Codecov.
|
|
Awesome. I'll do that. Assuming they have added it in 2.1? I know this because we have built the same functionality using 1.15 earlier. i.e a SavedModel directory from 2.x can be opened using 1.15 and then convert it to frozen model from there. And I had issues converting few models from 2.x to 1.15 |
|
Maybe with this new utility, they might convert it to a backward-compatible representation? Very unlikely |
|
This is slightly different though since it's TF2 doing the freezing. Since the frozen model is only useful for running in TF1, I'm expecting TF2 to fail if there's no corresponding op in GraphDef, so at least it would fail early on the TF2 side. |
|
That's a fair point. Let me find the models I tried with the old technique. |
TF2 supports freezing models, which can ben ran on TF1.15.
This PR adds a test on a MNIST-like model generated with Keras, exported through TF2 and that is ran on RedisAI.