Code refactoring, consistent error messages, and RedisAI_ModelRun_RedisCommand optimizations #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (only 1 full-loop vs 5)
…dd] enforced error reply string comparison on tests. [fix] error messages consistent across commands for tensor getting, etc...
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 56.81% 56.96% +0.14%
==========================================
Files 26 27 +1
Lines 5155 5080 -75
==========================================
- Hits 2929 2894 -35
+ Misses 2226 2186 -40
Continue to review full report at Codecov.
|
filipecosta90
changed the title
lantiga
reviewed
Apr 10, 2020
… [add] quick refactoring to have consistent command description on redisai.c
filipecosta90
changed the title
lantiga
approved these changes
Apr 10, 2020
Contributor
lantiga
left a comment
lantiga
left a comment
There was a problem hiding this comment.
Looks great. I've committed a couple of nits, we're good to merge
lantiga
added a commit
that referenced
this pull request
May 6, 2020
Code refactoring, consistent error messages, and RedisAI_ModelRun_RedisCommand optimizations (#321) * [wip] simplified argument processing on RedisAI_ModelRun_RedisCommand (only 1 full-loop vs 5) * [add] code refactoring to reduce duplicates and reduce complexity. [add] enforced error reply string comparison on tests. [fix] error messages consistent across commands for tensor getting, etc... * [add] increased coverage for tensorset and remove duplicate code * [fix] ensuring slaves synced on tests_pytorch:test_pytorch_scriptrun. [add] quick refactoring to have consistent command description on redisai.c * [fix] ERR error normalization. * Fix function names, error message, correct warning Co-authored-by: Luca Antiga <luca.antiga@orobix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current WIP
RedisModule_AutoMemory(ctx)fromRedisAI_TensorGet_RedisCommand,RedisAI_ModelSet_RedisCommand,RedisAI_ModelGet_RedisCommand,RedisAI_ModelDel_RedisCommand,RedisAI_ModelRun_RedisCommand,RedisAI_ScriptDel_RedisCommandqueuefromredisai.ctoutil/queue.c