Make atomic read for ref_count in DAG run_info free function. #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantiga
previously approved these changes
Nov 30, 2020
Contributor
lantiga
left a comment
lantiga
left a comment
There was a problem hiding this comment.
All good but there's a tab in there :-)
…d decrease the ref_count when a DAG op is finished. The original free function will be called at the end of the entire DAG run and assumes that there are no more copies of the DAG runInfo.
DvirDukhan
reviewed
Nov 30, 2020
…py function. PR fixes.
alonre24
force-pushed
the
Make_ref_count_atomic_read
branch
from
a38af82 to
037c97f
Compare
DvirDukhan
approved these changes
Dec 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 75.21% 75.30% +0.09%
==========================================
Files 22 22
Lines 5164 5167 +3
==========================================
+ Hits 3884 3891 +7
+ Misses 1280 1276 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.