Return an error when trying to run MODELRUN/SCRIPTRUN/DAGRUN through multi or lua #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…multi or lua (until we support non blocking executions)
DvirDukhan
previously approved these changes
Dec 3, 2020
lantiga
previously approved these changes
Dec 3, 2020
Contributor
lantiga
left a comment
lantiga
left a comment
There was a problem hiding this comment.
Looks good but I just saw there's a cluster-related failure we need to resolve (should be quick)
… the MULTI/LUA commands so they map to the same slot.
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 75.23% 75.25% +0.01%
==========================================
Files 22 22
Lines 5213 5217 +4
==========================================
+ Hits 3922 3926 +4
Misses 1291 1291
Continue to review full report at Codecov.
|
DvirDukhan
approved these changes
Dec 3, 2020
alonre24
deleted the
Not_allowing_blocking_executions_via_multi_and_lua
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary solution until we support non-blocking execution of these commands, since soon redis will not support client blocking through multi/lua (it will crash).