Skip to content

Conversation

@alonre24
Copy link
Collaborator

@alonre24 alonre24 commented Dec 6, 2020

Added a new flow test that loads this module and tests the LLAPI (currently contains a basic check only).
The module build is done by its own make file that is triggered in tests.sh before running flow tests.

@alonre24 alonre24 requested review from DvirDukhan and rafie December 6, 2020 10:54
@alonre24 alonre24 self-assigned this Dec 6, 2020
@alonre24 alonre24 force-pushed the Create_test_module_for_LLAPI branch from 5d36ca7 to b0e9de8 Compare December 6, 2020 10:56
…t loads this module and tests the LLAPI (currently contains a basic check only)
@alonre24 alonre24 force-pushed the Create_test_module_for_LLAPI branch from b0e9de8 to e480596 Compare December 6, 2020 11:05
@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #531 (145c4e9) into master (50b4b45) will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   75.29%   75.31%   +0.01%     
==========================================
  Files          22       22              
  Lines        5226     5226              
==========================================
+ Hits         3935     3936       +1     
+ Misses       1291     1290       -1     
Impacted Files Coverage Δ
src/model.c 71.46% <ø> (ø)
src/redisai.h 0.00% <ø> (ø)
src/redismodule.h 100.00% <ø> (ø)
src/tensor.c 82.73% <ø> (ø)
src/dag.c 87.12% <66.66%> (ø)
src/background_workers.c 87.43% <100.00%> (ø)
src/redisai.c 79.75% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b4b45...145c4e9. Read the comment docs.

@rafie
Copy link
Contributor

rafie commented Dec 6, 2020

Note: we should not be modifying redismodule.h.

@alonre24 alonre24 closed this Dec 7, 2020
@alonre24 alonre24 reopened this Dec 7, 2020
DvirDukhan
DvirDukhan previously approved these changes Dec 7, 2020
@alonre24 alonre24 merged commit e3f75e4 into master Dec 7, 2020
@alonre24 alonre24 deleted the Create_test_module_for_LLAPI branch December 7, 2020 12:26
@alonre24 alonre24 restored the Create_test_module_for_LLAPI branch December 14, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants