Fix unsafe dag release upon error #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iately after we free DAG runInfo that returned with an error.
DvirDukhan
reviewed
Dec 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
+ Coverage 75.76% 75.84% +0.07%
==========================================
Files 25 25
Lines 5401 5406 +5
==========================================
+ Hits 4092 4100 +8
+ Misses 1309 1306 -3
Continue to review full report at Codecov.
|
alonre24
force-pushed
the
Fix_unsafe_dag_release_upon_error
branch
from
990b968 to
2f0ec89
Compare
DvirDukhan
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#544
Bug fix (temporary until broader refactor).