-
Notifications
You must be signed in to change notification settings - Fork 106
Fix valgrind leaks (with minor refactor) #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
+ Coverage 76.01% 76.16% +0.14%
==========================================
Files 25 25
Lines 5508 5433 -75
==========================================
- Hits 4187 4138 -49
+ Misses 1321 1295 -26
Continue to review full report at Codecov.
|
|
Hi @alonre24 , can you provide a small description of the changes and what the leak was due to? |
lantiga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good catches
…to queue item(s) (even if the DAG is not finished), since we reinsert the item(s) to the queue (and reallocate memory).
RedisModuleString *mangled_key = RedisModule_CreateStringFromString(NULL, key);
A call for RedisModule_FreeString was added.