Skip to content

Conversation

@alonre24
Copy link
Collaborator

@alonre24 alonre24 commented Jan 3, 2021

Cancel the steps for modelget and modelset ops: modelset is done in parsing time, modelget in the reply.

Cancel the steps for modelget and modelset ops: modelset is done in parsing time, modelget in the reply.
@alonre24 alonre24 requested review from DvirDukhan and lantiga January 3, 2021 14:11
@alonre24 alonre24 self-assigned this Jan 3, 2021
@codecov
Copy link

codecov bot commented Jan 3, 2021

Codecov Report

Merging #551 (e56046f) into master (671e157) will decrease coverage by 1.21%.
The diff coverage is 94.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   75.74%   74.52%   -1.22%     
==========================================
  Files          35       35              
  Lines        5701     5644      -57     
==========================================
- Hits         4318     4206     -112     
- Misses       1383     1438      +55     
Impacted Files Coverage Δ
src/redisai.h 0.00% <ø> (ø)
src/tensor.c 82.01% <83.78%> (-1.97%) ⬇️
src/command_parser.c 91.87% <93.75%> (+1.87%) ⬆️
src/DAG/dag_parser.c 91.49% <95.23%> (+3.85%) ⬆️
src/DAG/dag.c 85.80% <100.00%> (-1.08%) ⬇️
src/redisai.c 83.02% <100.00%> (+0.02%) ⬆️
src/run_info.c 71.85% <100.00%> (-1.29%) ⬇️
src/modelRun_ctx.c 46.26% <0.00%> (-37.32%) ⬇️
src/script.c 63.39% <0.00%> (-16.34%) ⬇️
src/libtorch_c/torch_c.cpp 55.03% <0.00%> (-2.02%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 671e157...e56046f. Read the comment docs.

@alonre24 alonre24 merged commit 247c4e5 into master Jan 6, 2021
@alonre24 alonre24 deleted the DAGRUN_command_refactor branch January 6, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants