-
Notifications
You must be signed in to change notification settings - Fork 106
Refactor DAGRUN command parsing #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cancel the steps for modelget and modelset ops: modelset is done in parsing time, modelget in the reply.
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
==========================================
- Coverage 75.74% 74.52% -1.22%
==========================================
Files 35 35
Lines 5701 5644 -57
==========================================
- Hits 4318 4206 -112
- Misses 1383 1438 +55
Continue to review full report at Codecov.
|
- argv field in DagOp is pointing to the given DAGRUN command argv at the corresponding position (not allocated). - Fix cleanup in _MangleTensorsNames.
DvirDukhan
reviewed
Jan 4, 2021
DvirDukhan
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancel the steps for modelget and modelset ops: modelset is done in parsing time, modelget in the reply.