Skip to content

Conversation

@chayim
Copy link
Contributor

@chayim chayim commented May 20, 2021

Fixed the build of pytorch so that it now works on Jetson hardware. I've pushed dependencies to s3.

@chayim chayim requested review from DvirDukhan and alonre24 May 20, 2021 11:24
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #753 (f654bb8) into master (ffbf441) will decrease coverage by 0.58%.
The diff coverage is 56.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   79.38%   78.79%   -0.59%     
==========================================
  Files          48       49       +1     
  Lines        7476     7650     +174     
==========================================
+ Hits         5935     6028      +93     
- Misses       1541     1622      +81     
Impacted Files Coverage Δ
.../serialization/RDB/decoder/previous/v1/decode_v1.c 64.63% <ø> (ø)
...c/serialization/RDB/decoder/current/v2/decode_v2.c 52.12% <52.12%> (ø)
src/serialization/RDB/decoder/rai_rdb_decoder.c 66.66% <66.66%> (-33.34%) ⬇️
src/redisai.c 85.46% <100.00%> (+0.03%) ⬆️
src/serialization/RDB/decoder/decode_previous.c 75.00% <100.00%> (+8.33%) ⬆️
src/serialization/RDB/encoder/rai_rdb_encode.c 100.00% <100.00%> (ø)
src/serialization/RDB/encoder/v2/encode_v2.c 89.28% <100.00%> (ø)
src/redis_ai_types/script_type.c 65.00% <0.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b45ede...f654bb8. Read the comment docs.

Copy link
Collaborator

@alonre24 alonre24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put stempa, but I also think that we should test these things in CI (i.e., running our test suit on jetson). Is it something that we have on our list?

@chayim chayim merged commit 8a32f60 into master May 20, 2021
@chayim chayim deleted the ck-pytorch-on-jetson branch May 20, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants