Aof rewrite not covered fix #800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging a fix to RLTest that allows making aof rewrite without using rdb preamble - now we are covering aof rewrite in tests.
This includes fixing minor bug in model store command - AOF rewrite always sends 0 in the optional args of
batchsize,minbatchsize,minbatchtimeout, so we shouldn't return an error immediately if we see that one of an these args was given while another required arg is 0, unless it is non-zero by itself (for example,batchsize=0andminbatchsize=0is ok, butbatchsize=0andminbatchsize>0is not).