Skip to content

Conversation

@alonre24
Copy link
Collaborator

@alonre24 alonre24 commented Jun 27, 2021

After merging a fix to RLTest that allows making aof rewrite without using rdb preamble - now we are covering aof rewrite in tests.
This includes fixing minor bug in model store command - AOF rewrite always sends 0 in the optional args of batchsize, minbatchsize, minbatchtimeout, so we shouldn't return an error immediately if we see that one of an these args was given while another required arg is 0, unless it is non-zero by itself (for example, batchsize=0 and minbatchsize=0 is ok, but batchsize=0 and minbatchsize>0 is not).

@alonre24 alonre24 marked this pull request as ready for review July 6, 2021 10:10
@alonre24 alonre24 requested a review from DvirDukhan July 6, 2021 10:10
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #800 (f6ca7a6) into master (0000228) will increase coverage by 5.77%.
The diff coverage is 80.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
+ Coverage   74.11%   79.89%   +5.77%     
==========================================
  Files          39       53      +14     
  Lines        6081     8037    +1956     
==========================================
+ Hits         4507     6421    +1914     
- Misses       1574     1616      +42     
Impacted Files Coverage Δ
src/redis_ai_types/model_type.c 70.00% <ø> (ø)
src/redis_ai_types/script_type.c 70.00% <ø> (+5.00%) ⬆️
src/redis_ai_types/tensor_type.c 73.33% <ø> (ø)
src/serialization/AOF/rai_aof_rewrite.c 0.00% <0.00%> (ø)
tests/module/DAG_utils.c 88.23% <ø> (ø)
tests/module/LLAPI.c 74.46% <ø> (ø)
tests/unit/rmalloc.h 100.00% <ø> (ø)
tests/unit/unit_tests_err.cpp 100.00% <ø> (ø)
.../serialization/RDB/decoder/previous/v2/decode_v2.c 36.74% <36.74%> (ø)
src/backends/libtflite_c/tflite_c.cpp 58.16% <46.00%> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98bdb21...f6ca7a6. Read the comment docs.

@alonre24 alonre24 added ci-test and removed ci-test labels Jul 6, 2021
@alonre24 alonre24 merged commit 33c2b59 into master Jul 7, 2021
@alonre24 alonre24 deleted the AOF_rewrite_not_covered_fix branch July 7, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants