Skip to content

Conversation

@alonre24
Copy link
Collaborator

Following @AvitalFineRedis bug:
fix script execute parsing for cases that TIMEOUT arg is given and test it

@alonre24 alonre24 requested a review from DvirDukhan August 30, 2021 13:46
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #840 (7367b8e) into master (de0f302) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
+ Coverage   79.97%   80.02%   +0.04%     
==========================================
  Files          53       53              
  Lines        8009     8004       -5     
==========================================
  Hits         6405     6405              
+ Misses       1604     1599       -5     
Impacted Files Coverage Δ
src/execution/parsing/script_commands_parser.c 78.68% <100.00%> (+1.56%) ⬆️
src/redis_ai_objects/script.c 93.02% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e85a8...7367b8e. Read the comment docs.

@alonre24 alonre24 merged commit 59fae36 into master Aug 30, 2021
@alonre24 alonre24 deleted the fix_and_test_script_timeout branch August 30, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants