Slowlog implementation #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
==========================================
+ Coverage 81.21% 81.30% +0.09%
==========================================
Files 54 54
Lines 8145 8179 +34
==========================================
+ Hits 6615 6650 +35
+ Misses 1530 1529 -1
Continue to review full report at Codecov.
|
DvirDukhan
reviewed
Nov 30, 2021
DvirDukhan
left a comment
DvirDukhan
left a comment
There was a problem hiding this comment.
looks very good!
please note the comments on the python file
and updated redismodule.h file
for python <3.7 compatibility
search for the command in the last 10 commands
improved test_slowlog_time_dag_modelexecute_financialNet_autobatch test
RedisModule_BlockedClientMeasureTime functions (supported from version 6.2)
Added 'patch' argument for skip_if_not_version command. Added comments in test_slowlog_time_dag_modelexecute_financialNet_autobatch test.
until additional support will be added
DvirDukhan
approved these changes
Dec 1, 2021
GuyAv46
added a commit
that referenced
this pull request
Dec 2, 2021
* added slowlog timer implementation and updated redismodule.h file * added test for slowlog timer implementation * replaced time_ns() with time() for python <3.7 compatibility * splited asserts for better error catching * instead of assuming last command was DAGEXECUTE, search for the command in the last 10 commands * Added a wrapper for skipping test by redis version improved test_slowlog_time_dag_modelexecute_financialNet_autobatch test * added a check for version before using RedisModule_BlockedClientMeasureTime functions (supported from version 6.2) * Review fixes: Added 'patch' argument for skip_if_not_version command. Added comments in test_slowlog_time_dag_modelexecute_financialNet_autobatch test. * Valgring test will run on 6.0 redis, until additional support will be added
GuyAv46
added a commit
that referenced
this pull request
Dec 2, 2021
* Slowlog implementation (#883) * added slowlog timer implementation and updated redismodule.h file * added test for slowlog timer implementation * replaced time_ns() with time() for python <3.7 compatibility * splited asserts for better error catching * instead of assuming last command was DAGEXECUTE, search for the command in the last 10 commands * Added a wrapper for skipping test by redis version improved test_slowlog_time_dag_modelexecute_financialNet_autobatch test * added a check for version before using RedisModule_BlockedClientMeasureTime functions (supported from version 6.2) * Review fixes: Added 'patch' argument for skip_if_not_version command. Added comments in test_slowlog_time_dag_modelexecute_financialNet_autobatch test. * Valgring test will run on 6.0 redis, until additional support will be added * Slowlog impl fix (#885) * fix for circleci valgrind-cluster test: uses 6.2.5-x64-bullseye again * fix the debug messege: will display the test-function name now * update valgrind test to 6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.