Tmo changes#25
Merged
MeirShpilraien merged 18 commits intoRedisGears:masterfrom May 14, 2020
Merged
Conversation
Currently, the transformation function that converts a record to a hash is an extra parameter. Repurposing the mappings parameter and checking to see if it's callable
MeirShpilraien
left a comment
MeirShpilraien
left a comment
There was a problem hiding this comment.
@deji-alaran thanks, it looks very good!
One small comment about regex argument.
MeirShpilraien
approved these changes
May 14, 2020
MeirShpilraien
left a comment
MeirShpilraien
left a comment
There was a problem hiding this comment.
@deji-alaran thanks. approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes include: