Conversation
MeirShpilraien
force-pushed
the
added_db2_support
branch
from
4666134 to
48b14eb
Compare
|
|
|
What do you think of adding this docker and trying to add db2 to our CI workflow with github? Then we know the tests work. |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| 'LastName':'lname' | ||
| } | ||
|
|
||
| RGWriteBehind(GB, keysPrefix='emp', mappings=empMappings, connector=empConnector, name='empWriteBehind', version='99.99.99') |
There was a problem hiding this comment.
Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| 'LastName':'lname' | ||
| } | ||
|
|
||
| RGWriteBehind(GB, keysPrefix='emp', mappings=empMappings, connector=empConnector, name='empWriteBehind', version='99.99.99') |
There was a problem hiding this comment.
Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| 'LastName':'lname' | ||
| } | ||
|
|
||
| RGWriteBehind(GB, keysPrefix='emp', mappings=empMappings, connector=empConnector, name='empWriteBehind', version='99.99.99') |
There was a problem hiding this comment.
Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -0,0 +1,11 @@ | |||
| #!/bin/sh | |||
|
|
|||
| for i in `seq 1 10`; do | |||
There was a problem hiding this comment.
ShellCheck: Use $(...) notation instead of legacy backticks ....
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| for i in `seq 1 10`; do | ||
| docker logs db2|grep "Setup has completed" | ||
| if [ $? -eq 0 ]; then |
There was a problem hiding this comment.
ShellCheck: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| 'LastName':'lname' | ||
| } | ||
|
|
||
| RGWriteBehind(GB, keysPrefix='emp', mappings=empMappings, connector=empConnector, name='empWriteBehind', version='99.99.99') |
There was a problem hiding this comment.
Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -0,0 +1,11 @@ | |||
| #!/bin/sh | |||
|
|
|||
| for i in `seq 1 10`; do | |||
There was a problem hiding this comment.
ShellCheck: Use $(...) notation instead of legacy backticks ....
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -0,0 +1,11 @@ | |||
| #!/bin/sh | |||
|
|
|||
| for i in `seq 1 10`; do | |||
There was a problem hiding this comment.
ShellCheck: i appears unused. Verify use (or export if used externally).
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| for i in `seq 1 10`; do | ||
| docker logs db2|grep "Setup has completed" | ||
| if [ $? -eq 0 ]; then |
There was a problem hiding this comment.
ShellCheck: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| 'LastName':'lname' | ||
| } | ||
|
|
||
| RGWriteBehind(GB, keysPrefix='emp', mappings=empMappings, connector=empConnector, name='empWriteBehind', version='99.99.99') |
There was a problem hiding this comment.
Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -0,0 +1,11 @@ | |||
| #!/bin/sh | |||
|
|
|||
| for i in `seq 1 10`; do | |||
There was a problem hiding this comment.
ShellCheck: Use $(...) notation instead of legacy backticks ....
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -0,0 +1,11 @@ | |||
| #!/bin/sh | |||
|
|
|||
| for i in `seq 1 10`; do | |||
There was a problem hiding this comment.
ShellCheck: i appears unused. Verify use (or export if used externally).
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| for i in `seq 1 10`; do | ||
| docker logs db2|grep "Setup has completed" | ||
| if [ $? -eq 0 ]; then |
There was a problem hiding this comment.
ShellCheck: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| 'LastName':'lname' | ||
| } | ||
|
|
||
| RGWriteBehind(GB, keysPrefix='emp', mappings=empMappings, connector=empConnector, name='empWriteBehind', version='99.99.99') |
There was a problem hiding this comment.
Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
3 participants
Uh oh!
There was an error while loading. Please reload this page.