Adding cluster support for mongodb write behind#94
Merged
Conversation
Updating the documentation, and improving the tests
MeirShpilraien
previously approved these changes
Nov 30, 2021
MeirShpilraien
left a comment
There was a problem hiding this comment.
Looks good, my only comment is that maybe we want to follow the path of allow giving a callback for connection string so it can be read from db configuration, looks here:
Contributor
Author
Does anyone use this? I saw the idea and thought... I'd rather not embed a DSN in a database. For the record I could understand embedding it in a redis key (interesting?). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the ability to create custom mongodb:// style connection strings. This adds support for mongo clusters, and even Atlas