use operand matrix when available #1976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The TCK test: fails due to #1883. Given this optimization, records are now passed down immediately rather than being enqueued and popped, so the order they are received is reversed. This test previously passed accidentally. |
Codecov Report
@@ Coverage Diff @@
## master #1976 +/- ##
==========================================
+ Coverage 91.90% 92.66% +0.76%
==========================================
Files 239 239
Lines 20372 20512 +140
==========================================
+ Hits 18723 19008 +285
+ Misses 1649 1504 -145
Continue to review full report at Codecov.
|
swilly22
force-pushed
the
expand-into-optimization
branch
from
9d0443d to
58021fb
Compare
AviAvni
commented
Oct 10, 2021
AviAvni
commented
Oct 10, 2021
AviAvni
commented
Oct 10, 2021
AviAvni
commented
Oct 10, 2021
| if(r == NULL) break; | ||
|
|
||
| // set the matrix on first invocation | ||
| if(op->M == NULL && op->single_operand) { |
There was a problem hiding this comment.
why this is not on the init function? is optimize could make not operand to operand?
AviAvni
commented
Oct 10, 2021
| Record_PersistScalars(childRecord); | ||
| op->records[op->record_count] = childRecord; | ||
| // store received record | ||
| // TODO: not sure if necessary when we're streaming records |
There was a problem hiding this comment.
how to check if this necessary
swilly22
approved these changes
Oct 10, 2021
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* use operand matrix when available * Add ExpandIntoSimpleConsume routine * refactor expand_into op * resolve expand-into optimization at init time * disable only param test Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: swilly22 <roi@redislabs.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.