Expose the statistics data as properties #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swilly22
suggested changes
Oct 3, 2017
redisgraph/query_result.py
Outdated
|
|
||
| def __init__(self, result_set, statistics): | ||
| self.result_set = result_set | ||
| (self.statistics, self.parsed_statistics) = \ |
Contributor
There was a problem hiding this comment.
Can't we just say self.statistics = statistics?
redisgraph/query_result.py
Outdated
| print(stat) | ||
|
|
||
| def _retrieve_data_from_statistics(self, statistics): | ||
| parsed_statistics = { |
Contributor
There was a problem hiding this comment.
Wouldn't you prefer to have a class variable foreach statistic?
e.g. self.labels_added = self._get_value(self.LABELS_ADDED)
Moved the ResultQuery class and exposed the statistics data as properties. (Those changes in redisgraph-py and redis-graph will work also without the changes in the C code because it will retrieve the data as 0s)
aweyl
force-pushed
the
change_query_result
branch
from
aaaf796 to
f20a22d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the ResultQuery class and exposed the statistics data as properties.
(Those changes in redisgraph-py and redis-graph will work also without the changes in the C code because it will retrieve the data as 0s)