Python3 compatibility #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swilly22
reviewed
Nov 16, 2017
redisgraph/client.py
Outdated
| data = response[0] | ||
| statistics = response[1] | ||
| result_set = [res.split(',') for res in data] | ||
| result_set = [res.decode().split(',') for res in data] |
Contributor
There was a problem hiding this comment.
Why do we need decode here?
Contributor
Author
There was a problem hiding this comment.
Looks like an artefact of trying to track down the issue that can be removed.
swilly22
reviewed
Nov 18, 2017
| @staticmethod | ||
| def _get_value(prop, statistics): | ||
| for stat in statistics: | ||
| stat = stat.decode() |
Contributor
There was a problem hiding this comment.
I'm not that familiar with Python3, could you explain why do we need decode here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to tweak a couple things to get this running in python 3 - tested in 2.7.13 for backwards compatibility.