Skip to content

Conversation

@DvirDukhan
Copy link
Contributor

added check for runtime exception. added tests for compile-time and runtime exceptions.

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1287f21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   93.67%           
=========================================
  Files             ?        5           
  Lines             ?       79           
  Branches          ?        6           
=========================================
  Hits              ?       74           
  Misses            ?        5           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1287f21...ff3e848. Read the comment docs.

src/resultSet.js Outdated
if (resp.length < 3) {
this._statistics = new Statistics(resp[resp.length - 1]);
if(Array.isArray(resp)) {
var len = resp.length
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let e =  resp[len-1]

@DvirDukhan DvirDukhan merged commit 38611ae into master Sep 15, 2019
@gkorland gkorland deleted the runtime-exceptions branch April 5, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants