#RI-2946, RI-2944 - add claim message, ack message#717
Merged
AmirAllayarovSofteq merged 10 commits intomainfrom May 31, 2022
Merged
#RI-2946, RI-2944 - add claim message, ack message#717AmirAllayarovSofteq merged 10 commits intomainfrom
AmirAllayarovSofteq merged 10 commits intomainfrom
Conversation
Contributor
|
I found a few critical bugs:
For feature please schedule an internal demo meeting (me or Roman, someone from QA, BA and Andrei) before create a pull request |
rsergeenko
reviewed
May 30, 2022
…nto feature/RI-2946_RI-2944_messages_actions
rsergeenko
reviewed
May 31, 2022
| <EuiFieldNumber | ||
| name="minIdleTime" | ||
| id="minIdleTime" | ||
| data-testid="port" |
rsergeenko
reviewed
May 31, 2022
| acknowledge: (entry: string) => void | ||
| } | ||
|
|
||
| const AckPopover = ({ id, isOpen, closePopover, showPopover, acknowledge }:Props) => ( |
Contributor
There was a problem hiding this comment.
please, destruct inside component
const { ... } = props
and add space after :
| color="warning" | ||
| iconType="trash" | ||
| onClick={() => acknowledge(id)} | ||
| data-testid="acknowledge" |
Contributor
There was a problem hiding this comment.
better use acknowledge-submit
rsergeenko
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.