Skip to content

MOD-8480: Backport to 8.0: update redismodule-rs to 2.1.2 and fix codecov (#1326)#1327

Merged
oshadmi merged 1 commit into8.0from
oshadmi_update-redismodule-rs-to-2.1.2
Feb 27, 2025
Merged

MOD-8480: Backport to 8.0: update redismodule-rs to 2.1.2 and fix codecov (#1326)#1327
oshadmi merged 1 commit into8.0from
oshadmi_update-redismodule-rs-to-2.1.2

Conversation

@oshadmi
Copy link
Collaborator

@oshadmi oshadmi commented Feb 27, 2025

Backport #1326 to 8.0

  • MOD-8480: update redismodule-rs to 2.1.2 on master

    • try building with newer readies
  • turn on shell debug mode

  • update readies commit

    • print coverage tools version
    • fix clang-format not being a slave in update_clang_alternatives.sh
    • print clang++ version
    • cleanup a bit
    • use all option in llvm.sh
    • more generic update alternatives script
    • test
    • small fix
    • try removing before installing
    • fix deprecated default_features by moving it to be default-features
    • print clang version
    • update rust
    • update coverage flag
    • use rustc llvm version to avoid versioning errors in code coverage

Co-authored-by: jonathan keinan jonathan.keinan@redis.com
(cherry picked from commit 1da355d)

* MOD-8480: update redismodule-rs to 2.1.2 on master

* * try building with newer readies

* turn on shell debug mode

* update readies commit

* * print coverage tools version

* * fix clang-format not being a slave in update_clang_alternatives.sh

* * print clang++ version

* * cleanup a bit

* * use all option in llvm.sh

* * more generic update alternatives script

* * test

* * small fix

* * try removing before installing

* * fix deprecated default_features by moving it to be default-features

* * print clang version

* * update rust

* * update coverage flag

* * use rustc llvm version to avoid versioning errors in code coverage

---------

Co-authored-by: jonathan keinan <jonathan.keinan@redis.com>
(cherry picked from commit 1da355d)
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (8.0@765bcdd). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             8.0    #1327   +/-   ##
======================================
  Coverage       ?   78.12%           
======================================
  Files          ?       15           
  Lines          ?     3872           
  Branches       ?        0           
======================================
  Hits           ?     3025           
  Misses         ?      847           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oshadmi oshadmi merged commit 35c9f9b into 8.0 Feb 27, 2025
17 checks passed
@oshadmi oshadmi deleted the oshadmi_update-redismodule-rs-to-2.1.2 branch February 27, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants