Skip to content

fix memory test #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AvivDavid23 merged 3 commits into from
Aug 24, 2025
Merged

fix memory test #1376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e51a5cc
fix memory test
AvivDavid23 Aug 21, 2025
e7e3f33
more tests fixes
AvivDavid23 Aug 21, 2025
8f83dae
bump ijson
AvivDavid23 Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ members = [
]

[workspace.dependencies]
ijson = { git="https://github.com/RedisJSON/ijson", rev="adf71f0c5e9a9356ac0d22d9e93b9f87a2ff4fc1", default-features=false}
ijson = { git="https://github.com/RedisJSON/ijson", rev="d3ec366ea9fc4788ab54642aab709d1e05c31f6f", default-features=false}
serde_json = { version="1", features = ["unbounded_depth"]}
serde = { version = "1", features = ["derive"] }
serde_derive = "1"
Expand Down
2 changes: 1 addition & 1 deletion redis_json/src/ivalue_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ mod tests {
}"#;
let value = serde_json::from_str(json).unwrap();
let res = RedisIValueJsonKeyManager::get_memory(&value).unwrap();
assert_eq!(res, 1168);
assert_eq!(res, 736);
}

/// Tests the deserialiser of IValue for a string with unicode
Expand Down
4 changes: 2 additions & 2 deletions tests/pytest/test_multi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ def testDebugCommand(env):
# Test multi
# json.get a $..a ==> "[{},[],\"str\",42,1.2,false,null]"
res = r.execute_command('JSON.DEBUG', 'MEMORY', 'doc1', '$..a')
r.assertEqual(res, [8, 8, 32, 8, 16, 8, 8])
r.assertEqual(res, [8, 8, 8, 8, 16, 8, 8])

# Test single
res = r.execute_command('JSON.DEBUG', 'MEMORY', 'doc1', '$.nested2.a')
Expand All @@ -855,7 +855,7 @@ def testDebugCommand(env):

# Test missing path (defaults to root)
res = r.execute_command('JSON.DEBUG', 'MEMORY', 'doc1')
r.assertEqual(res, 1440)
r.assertEqual(res, 1080)

# Test missing subcommand
r.expect('JSON.DEBUG', 'non_existing_doc', '$..a').raiseError()
Expand Down
2 changes: 1 addition & 1 deletion tests/pytest/test_resp3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def test_resp_default_path(self):
r.assertEqual(r.execute_command('JSON.OBJKEYS', 'test_resp3'), ['a'])
r.assertEqual(r.execute_command('JSON.OBJLEN', 'test_resp3'), 1)
r.assertEqual(r.execute_command('JSON.TYPE', 'test_resp3'), ['object'])
r.assertEqual(r.execute_command('JSON.DEBUG', 'MEMORY', 'test_resp3'), 536)
r.assertEqual(r.execute_command('JSON.DEBUG', 'MEMORY', 'test_resp3'), 464)
r.assertEqual(r.execute_command('JSON.DEL', 'test_resp3'), 1)

# Test JSON.strX commands on object type when default path is used
Expand Down