MOD-4107 Limit json doc depth to 128#1487
Merged
AvivDavid23 merged 9 commits intomasterfrom Jan 21, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1487 +/- ##
==========================================
+ Coverage 77.55% 77.82% +0.27%
==========================================
Files 15 15
Lines 3832 3897 +65
==========================================
+ Hits 2972 3033 +61
- Misses 860 864 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
galcohen-redislabs
approved these changes
Jan 20, 2026
gabsow
reviewed
Jan 22, 2026
| fn get_long(&self) -> i64; | ||
| fn get_double(&self) -> f64; | ||
|
|
||
| fn calculate_value_depth(&self) -> usize { |
Collaborator
There was a problem hiding this comment.
mybe this is too costy in terms of prefomence
AvivDavid23
added a commit
that referenced
this pull request
Jan 27, 2026
This reverts commit 50f3765.
AvivDavid23
added a commit
that referenced
this pull request
Feb 24, 2026
* MOD-4107 Limit json doc depth to 128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Imposes a strict depth cap to prevent excessively nested JSON values.
MAX_DEPTH=128andSelectValue::calculate_value_depth(); tracks traversal depth infollow_pathset_value,dict_add,arr_append,arr_insert, andmergeviacan_merge()witherr_recursion_limit_exceededfrom_str(..., limit_depth=true))usizedepth)JSON.SET/MSET, array ops, andJSON.MERGEWritten by Cursor Bugbot for commit 77954da. This will update automatically on new commits. Configure here.