Skip to content

Avoid panic on unimplemeted filter syntax #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oshadmi merged 3 commits into from
Oct 31, 2021
Merged

Avoid panic on unimplemeted filter syntax #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c40972
Avoid panic on unimplemeted filter syntax
oshadmi Oct 31, 2021
263ffd5
Unimplemeted filter syntax - add unit test
oshadmi Oct 31, 2021
6c92d87
Unimplemeted filter syntax - add unit test (2)
oshadmi Oct 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/select/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,8 @@ where

fn visit_keys(&mut self, keys: &[String]) {
if !self.selector_filter.is_term_empty() {
unimplemented!("keys in filter");
//unimplemented!("keys in filter"); // TODO: Filter Enhancement
return;
}

if let Some(ParseToken::Array) = self.tokens.pop() {
Expand Down Expand Up @@ -825,7 +826,8 @@ where

fn visit_range(&mut self, from: &Option<isize>, to: &Option<isize>, step: &Option<usize>) {
if !self.selector_filter.is_term_empty() {
unimplemented!("range syntax in filter");
//unimplemented!("range syntax in filter"); // TODO: Filter Enhancement
return;
}

if let Some(ParseToken::Array) = self.tokens.pop() {
Expand Down Expand Up @@ -864,7 +866,8 @@ where

fn visit_union(&mut self, indices: &[isize]) {
if !self.selector_filter.is_term_empty() {
unimplemented!("union syntax in filter");
//unimplemented!("union syntax in filter"); // TODO: Filter Enhancement
return;
}

if let Some(ParseToken::Array) = self.tokens.pop() {
Expand Down
49 changes: 49 additions & 0 deletions tests/filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,4 +277,53 @@ fn bugs38_array_notation_in_filter() {
]),
json!([{"seq": 2, "subKey": "subKey2"}]),
);
}

#[test]
fn unimplemented_in_filter() {
setup();

let json = json!([{
"store": {
"book": [
{"authors": [
{"firstName": "Nigel",
"lastName": "Rees"},
{"firstName": "Evelyn",
"lastName": "Waugh"}
],
"title": "SayingsoftheCentury"},
{"authors": [
{"firstName": "Herman",
"lastName": "Melville"},
{"firstName": "Somebody",
"lastName": "Else"}
],
"title": "MobyDick"}
]}
}]);

// Should not panic
// unimplemented!("range syntax in filter")
select_and_then_compare(
"$.store.book[?(@.authors[0:1])]",
json.clone(),
json!([]),
);

// Should not panic
// unimplemented!("union syntax in filter")
select_and_then_compare(
"$.store.book[?(@.authors[0,1])]",
json.clone(),
json!([]),
);

// Should not panic
// unimplemented!("keys in filter");
select_and_then_compare(
"$.store[?(@.book['authors', 'title'])]",
json.clone(),
json!([]),
);
}