Skip to content

Conversation

@yuvallevy2
Copy link
Contributor

No description provided.

kaitlynmichael
kaitlynmichael previously approved these changes Jul 12, 2021
Copy link
Collaborator

@kaitlynmichael kaitlynmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments. Nothing big to correct here.

Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
yuvallevy2 and others added 9 commits July 12, 2021 17:16
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
@yuvallevy2 yuvallevy2 merged commit 4108650 into master Jul 12, 2021
Copy link
Contributor

@amiramm amiramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @yuvallevy2 please see minor corrections

| Services Rigger | `redislabs/k8s-controller:6.0.20-4` | `redislabs/k8s-controller:6.0.20-4` |
| Redis Enterprise | `redislabs/redis:6.0.20-97` | `redislabs/redis:6.0.20-97.rhel7-openshift` |
| Operator | `redislabs/operator:6.0.20-12` | `redislabs/operator:6.0.20-12` |
| Services Rigger | `redislabs/k8s-controller:6.0.20-12` | `redislabs/k8s-controller:6.0.20-12` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Services Rigger | `redislabs/k8s-controller:6.0.20-12` | `redislabs/k8s-controller:6.0.20-12` |
| Services Rigger | `redislabs/k8s-controller:6.0.20-12` | `redislabs/services-manager:6.0.20-12` |

kubectl apply -f service_account.yaml
kubectl apply -f crds/v1/rec_crd.yaml
kubectl apply -f crds/v1alpha1/redb_crd.yaml
kubectl apply -f admission-service.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuvallevy2 will this work without step 5 below?

| VMWare TKGIE** 1.7 (K8s 1.16) | deprecated |
| VMWare TKGIE** 1.8 (K8s 1.17) | deprecated |
| VMWare TKGIE*** 1.10 (K8s 1.19) | supported |
| AKS 1.18 | supported |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| AKS 1.18 | supported |
| AKS 1.18 | supported |
| EKS 1.19. | supported |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants