Skip to content

Conversation

@Hiieu
Copy link
Contributor

@Hiieu Hiieu commented Apr 21, 2022

  • Removed a deprecated attribute: persistent_storage_encryption
  • updated changelog
  • updated the url to the QA server

@Hiieu Hiieu requested review from greg-oc and trentrosenbaum April 21, 2022 12:50
@Hiieu
Copy link
Contributor Author

Hiieu commented Apr 21, 2022

TODO: Update go.mod once the changes in this PR are merged and a new version of the rediscloud-go-api client is released.

Copy link
Contributor

@greg-oc greg-oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Hiieu Hiieu merged commit 44e7d35 into main Apr 26, 2022
@Hiieu Hiieu deleted the remove_persistent_storage_encryption branch April 26, 2022 07:38
burythehammer pushed a commit that referenced this pull request Nov 10, 2025
* remove persistent_storage_encryption
* update changelog
* update the url to the qa server
* update rediscloud-go-api to v0.1.7

Co-authored-by: Hieu Doan <hiieu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants