[MOD-15026] allow passing startup grace#247
Merged
GuyAv46 merged 2 commits intoRedisLabsModules:masterfrom Apr 23, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 32.46% 34.26% +1.79%
==========================================
Files 17 17
Lines 2597 2697 +100
==========================================
+ Hits 843 924 +81
- Misses 1754 1773 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
GuyAv46
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
RLTest's
StandardEnv.startEnvhas a hardcodedtime.sleep(0.1)betweensubprocess.Popen(redis-server ...)and the liveness probe (_isAlive+waitForRedisToStart→wait_for_conn). That 100 ms grace period is the only window during which the framework tolerates a redis-server that exits on its own (e.g. because aloadmoduleargument was rejected and the server aborted).For tests that intentionally pass invalid module args and expect the server to fail to start, this is racy:
_isAlivereturnsFalse,masterProcessis set toNone,Env.__init__returns cleanly, and the test can assertnot env.isUp()._isAlivereturnsTrue, the framework opens a connection, andwait_for_conneventually raisesException('Redis server is dead ...'). That exception is raised from insideEnv.__init__beforeRTestInstance.currEnvis assigned, so even when the test's owntry/exceptswallows it, the runner reports a spurious<Environment destroyed>failure at teardown.Concretely, this has been making
testconfigMultiTextOffsetDeltaSlopNegflaky in RediSearch, where we passMULTI_TEXT_SLOP -1on purpose and expect the module to reject it during init.What this PR does
Adds a
startupGraceSecsparameter (default0.1, i.e. identical to the current behavior) toStandardEnv.__init__andEnv.__init__, plumbed throughgetEnvKwargs, and replaces the hardcodedtime.sleep(0.1)instartEnvwithtime.sleep(self.startupGraceSecs).Tests that expect the server to abort during module init can then bump the grace period, e.g.:
This keeps the liveness probe from racing with the abort without affecting any existing caller.