Please drop -mpopcnt from CFLAGS

[lamby]

RediSearch stopped being compilable in Debian (see #896593) due to the use of -mpopcnt. This is not portable, alas.

[dvirsky]

I don't want to completely drop it, but let's figure out a way to find out whether it's supported or not.

[lamby]

That's not possible at compile-time I'm afraid. POPCNT was introduced in SSE 4.2 so if my processor is SSE 4.1 the instruction will be simply missing and I'll get an illegal instruction error at runtime...

[dvirsky]

It's not a problem to test for it though.

[dvirsky]

Oh I get what you mean, compile time is irrelevant in this case.

Anyway it's not that important, I can just go fo a naive, slightly slower implementation of it and that's it.

[dvirsky]

@lamby please try 1.0, I've removed the flag and any reference to the instructions, and went with a simple table based population counting method.

[lamby]

Thanks. I already removed the addition to CFLAGS in the 1.0.10-2 upload so am happy for wait for the next tagged/official release. :) Thanks again :-)

[dvirsky]

Removing the flag without modifying the code will make the module fail in some systems.

…

On Mon, Apr 23, 2018 at 6:23 PM Chris Lamb ***@***.***> wrote: Thanks. I already removed the addition to CFLAGS in the 1.0.10-2 upload <https://tracker.debian.org/news/951425/accepted-redisearch-1010-2-source-amd64-all-into-unstable/> so am happy for wait for the next tagged/official release. :) Thanks again :-) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#313 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAetulgOowM8LnNVUE3u0SHyUX0JGRnvks5trhwXgaJpZM4TfArj> .

[lamby]

Removing the flag without modifying the code will make the module fail in some systems.

How come, out of interest?

[dvirsky]

It will just crash with "undefined symbol" when you try to load the module.

…

On Tue, Apr 24, 2018 at 5:46 AM Chris Lamb ***@***.***> wrote: Removing the flag without modifying the code will make the module fail in some systems. How come, out of interest? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#313 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAetuhhyFraVUrfZKuc50Cis6-IsT6yfks5trrwZgaJpZM4TfArj> .

[lamby]

Thanks! Uploaded in redisearch 1.0.10-3 :)

[dvirsky]

@lamby I've released 1.1.0 today, a pretty big change.