Skip to content
This repository was archived by the owner on Jan 24, 2023. It is now read-only.

Conversation

@ashtul
Copy link
Contributor

@ashtul ashtul commented Dec 18, 2019

Added pipeline option to the client
With tests

@lgtm-com
Copy link

lgtm-com bot commented Dec 18, 2019

This pull request introduces 2 alerts when merging 188c469 into 25c5cc6 - view on LGTM.com

new alerts:

  • 1 for Missing call to __del__ during object destruction
  • 1 for Missing call to __init__ during object initialization

itamarhaber
itamarhaber previously approved these changes Dec 18, 2019
Copy link

@itamarhaber itamarhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the docstring for the Pipeline class.

return p

class Pipeline(Pipeline, Client):
"Pipeline for ReJSONClient"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tsk tsk tsk

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #30   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         244    264   +20     
=====================================
+ Hits          244    264   +20
Impacted Files Coverage Δ
test_commands.py 100% <100%> (ø) ⬆️
redistimeseries/client.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e46d9...730e11a. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Dec 18, 2019

This pull request introduces 2 alerts when merging 44cc3da into 25c5cc6 - view on LGTM.com

new alerts:

  • 1 for Missing call to __del__ during object destruction
  • 1 for Missing call to __init__ during object initialization

@ashtul ashtul requested a review from itamarhaber December 18, 2019 13:25
@lgtm-com
Copy link

lgtm-com bot commented Dec 18, 2019

This pull request introduces 2 alerts and fixes 6 when merging 49018a1 into 25c5cc6 - view on LGTM.com

new alerts:

  • 1 for Missing call to __del__ during object destruction
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 5 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@ashtul
Copy link
Contributor Author

ashtul commented Dec 20, 2019

@itamarhaber

@lgtm-com
Copy link

lgtm-com bot commented Dec 20, 2019

This pull request fixes 5 alerts when merging 730e11a into b2e46d9 - view on LGTM.com

fixed alerts:

  • 5 for Unused import

@gkorland gkorland merged commit 132c751 into master Dec 20, 2019
@gkorland gkorland deleted the Add-pipeline branch December 20, 2019 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants