fix: Response objects couldn't open#1867
Merged
Oprysk merged 2 commits intoRedocly:masterfrom Jan 24, 2022
Merged
Conversation
3 tasks
DepickereSven
commented
Jan 22, 2022
| .should('have.attr', 'aria-expanded', 'true') | ||
| .parent() | ||
| .find('div h5') | ||
| .then($h5 => $h5[0].firstChild!.nodeValue!.trim()) |
Contributor
Author
There was a problem hiding this comment.
I wanted to get the value of the h5 element.
If I would just do .should('have.text', 'Response Schema:') on that h5 it would throw an error. Because the span values would also be in that comparison.
DepickereSven
changed the title
Contributor
|
@DepickereSven Thank you for the fix! |
Oprysk
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
When you clicked on a response object you would get the following error.
Reference
No reference
Testing
Added some cypress tests
Screenshots (optional)
Check yourself