Complementary CMake updates#20
Conversation
📝 WalkthroughWalkthroughThe PR removes Boost.UT module and its main, updates CMake presets to prefer clang with C17/C++23 and related flags, enables IPO via CMake variable, adds [[nodiscard]]/constexpr/noexcept to several math templates, lowers the __cplusplus static_assert, and expands the README NOTE block. ChangesTest Infrastructure & Build System Modernization
Code Quality & Documentation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@OldDev78 Could you add this check in Compiler.cmake? |
CMake already performs most compiler checks in the generation stage. If the compiler does not support that standard version flag - or c++ modules, for that matter - generation fails with an error message. I can improve the static assert message already present in definitions.cppm that is also there to further gate the supported standard. This did remind me to rewrite the link timer optimization flag as a (portable) property in CMake though. |
[[nodiscard]]to some math functionsSummary by CodeRabbit
Chores
Documentation
Refactor