BLAS: inline SCABS1/DCABS1 into CAXPY/ZAXPY as statement function CABS1#1218
Merged
langou merged 1 commit intoReference-LAPACK:masterfrom Mar 28, 2026
Merged
Conversation
Replace external function references to SCABS1 and DCABS1 with a local statement function CABS1 in CAXPY and ZAXPY respectively, eliminating the dependency on those auxiliary routines.
langou
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @langou, this PR removes the dependency on the auxiliary routines SCABS1 and DCABS1 by inlining the equivalent logic into CAXPY and ZAXPY as a local statement function named CABS1.
Changes:
CAXPY: replace EXTERNAL SCABS1 with a local statement function CABS1(CDUM) = ABS(REAL(CDUM)) + ABS(AIMAG(CDUM))
ZAXPY: replace EXTERNAL DCABS1 with a local statement function CABS1(ZDUM) = ABS(DBLE(ZDUM)) + ABS(DIMAG(ZDUM))
The function name CABS1 is used in both routines for consistency, as the semantics are identical; only the precision of the dummy argument differs.
cf. #1200