TESTING/EIG: use named ONE constants in several error-exit tests#1230
Merged
langou merged 2 commits intoReference-LAPACK:masterfrom Apr 11, 2026
Merged
Conversation
Replace hard-coded 1./1.D0 literals with the named constant ONE in several TESTING/EIG error-exit test routines. Add missing ONE parameter declarations where needed so the test setup code follows the surrounding named-constant style.
langou
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces hard-coded
1./1.D0literals with the namedconstant
ONEin severalTESTING/EIGerror-exit test routines.Where needed, it also adds missing
ONEparameter declarations sothe setup code follows the surrounding named-constant style.
No functional change is intended.
Details
Several
TESTING/EIGerror-exit tests initialize matrices withexpressions such as:
1. / REAL(I+J)1.D0 / DBLE(I+J)This change rewrites those initializations to use
ONEinstead.The goal is simply to make constant usage more consistent across
the test sources and to reduce hard-coded numeric literals in the
setup code.
Testing