Rearrange some cmake setup steps#169
Merged
julielangou merged 2 commits intoReference-LAPACK:masterfrom Oct 11, 2017
Merged
Conversation
Consolidate some of the CMAKE_BUILD_TYPE code. Move the BUILD_SHARED_LIBS declaration before it is used, if it matters. Move the BUILD_TESTING declaration before the CTest stuff so that our default of OFF is respected. Otherwise it is defaulting to ON.
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 82.25% 82.25%
=======================================
Files 1822 1822
Lines 177187 177187
=======================================
Hits 145752 145752
Misses 31435 31435Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate some of the CMAKE_BUILD_TYPE code.
Move the BUILD_SHARED_LIBS declaration before it is used, if it matters.
Move the BUILD_TESTING declaration before the CTest stuff so that our
default of OFF is respected. Otherwise it is defaulting to ON.