cblas: add include directory to target#170
cblas: add include directory to target#170julielangou merged 2 commits intoReference-LAPACK:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
=======================================
Coverage 82.25% 82.25%
=======================================
Files 1822 1822
Lines 177187 177187
=======================================
Hits 145752 145752
Misses 31435 31435Continue to review full report at Codecov.
|
| VERSION ${LAPACK_VERSION} | ||
| SOVERSION ${LAPACK_MAJOR_VERSION} | ||
| ) | ||
| target_include_directories(cblas PUBLIC |
There was a problem hiding this comment.
CMake minimum version is set to 2.8.10:
Line 1 in e774b43
Command target_include_directories is not available:
This can be fixed by updating minimum requirement to 2.8.12:
If update to 2.8.12 is acceptable, alternatively you can use INCLUDES DESTINATION include here:
Lines 102 to 107 in e774b43
Docs:
There was a problem hiding this comment.
I think INCLUDES DESTINATION is also a v2.8.12 feature. I didn't find it in the v2.8.10 documentation
https://cmake.org/cmake/help/v2.8.10/cmake.html#command:install
There was a problem hiding this comment.
I think INCLUDES DESTINATION is also a v2.8.12 feature
Yes, that's what I meant by "If update to 2.8.12 is acceptable, alternatively..." 😉
- needed for `target_include_directories()`
add include directories to target. With this change in a cmake project one can link cblas with just the following