reverting incorrect changes made to syntax for CMAKE_Fortran_FLAGS with Intel/XL compilers#388
Merged
julielangou merged 11 commits intoReference-LAPACK:masterfrom Feb 20, 2020
Merged
Conversation
With MinGW the build fails for some LAPACKE xgesvd routines with: lapacke_cgesvdq.c:74:5: error: aggregate value used where an integer was expected Seems the C2INT macro is useful there.
…ndle row-major layout by transposing the matrix into a temporary array, and then transposing the result back into the originally matrix after the computations have completed. So, in the case where eigenvectors are requested, the entire matrix will be overwritten with the eigenvectors, meaning that we need to copy the entire result back after computations have completed. We changed the interface to copy the entire result back after the computation is done when eigenvectors are requested.
The documentation specified arguments as REAL arrays, however they should be COMPLEX. Signed-off-by: Nick Papior <nickpapior@gmail.com>
raovgarimella
force-pushed
the
master
branch
from
6f1c9f7 to
3aba241
Compare
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 81.86% 83.24% +1.38%
==========================================
Files 1863 1808 -55
Lines 181008 170181 -10827
==========================================
- Hits 148174 141664 -6510
+ Misses 32834 28517 -4317
Continue to review full report at Codecov.
|
Contributor
|
Thanks! |
christoph-conrads
pushed a commit
to christoph-conrads/lapack
that referenced
this pull request
May 23, 2021
reverting incorrect changes made to syntax for CMAKE_Fortran_FLAGS with Intel/XL compilers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commits 7c98411 and ac26c7c introduced an incorrect syntax for setting CMAKE_Fortran_FLAGS. This variable was treated as a list instead of a string and was generating incorrect syntax. Verified fix with a successful Intel 18 configuration on linux.
References issue #336