[BLAS] Skip calculation of ROE when SCALE is zero#454
Merged
langou merged 1 commit intoReference-LAPACK:masterfrom Oct 17, 2020
Merged
[BLAS] Skip calculation of ROE when SCALE is zero#454langou merged 1 commit intoReference-LAPACK:masterfrom
langou merged 1 commit intoReference-LAPACK:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 1863 1863
Lines 181096 181096
=======================================
Hits 148263 148263
Misses 32833 32833 Continue to review full report at Codecov.
|
Contributor
|
Yes, that's a good idea. Thanks @timleslie for the PR |
christoph-conrads
pushed a commit
to christoph-conrads/lapack
that referenced
this pull request
May 23, 2021
[BLAS] Skip calculation of ROE when SCALE is zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes in
SROTGandDROTGwill avoid an unnecessary comparison whenSCALEis zero.