Revert "feat(collapse): support screen reader"#179
Merged
TremayneChrist merged 1 commit intodevelopfrom Jan 27, 2022
Merged
Conversation
This reverts commit 158f031.
Deploying with
|
| Latest commit: |
087b248
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f987eeb.refinitiv-ui.pages.dev |
Collaborator
|
Hi Trem, I understand you about controlling the quality but if you want a team member who has deep accessibility knowledge to review all PR in this sprint, I think we will not close many cards because I have @wsuwt only in Bangkok Team who has deep accessibility knowledge and He might not bandwidth to review all of accessibility PR. |
Collaborator
Author
|
Quality is of upmost importance. We should not merge without a solid review of code. Forcing this to push tickets through a sprint is not justified. |
Collaborator
|
I agree with you, no problem, the product quality should come first. |
Collaborator
Author
|
We'll revert this today and you can restore your old branch and submnit a new new PR for review. |
goremikins
approved these changes
Jan 27, 2022
TremayneChrist
added a commit
that referenced
this pull request
Jan 27, 2022
* refactor(pagination): remove part info * feat(pagination): support max unknown * refactor(pagination): remove unused function `pageInfo` * refactor(pagination): handle input page selection * refactor(pagination): add state for check input is editing * refactor(pagination): request update element on blur * test(pagination): update transform text input selected test case * refactor(pagination): use state decorator to auto update the input * refactor(pagination): deprecate page, totalItems, page-changed (#78) * chore(pagination): add max attribute demo * test: fix test all fail when using setTimeout * refactor(pagination): update getter setter and internal value * chore(pagination): update demo page * refactor(pagination): update internal max and property change events * fix(pagination): max limit does not work * refactor(pagination): validate value is in supported range * refactor(pagination): add range value validation * refactor(pagination): add deprecation notice on getter * docs(pagination): remove type from jsdoc * test(pagination): update to support value, max properties * fix(pagination): getter in internal will retrigger incorrect warning message * refactor(pagination): reset input behavior for end users * refactor(pagination): reset input behavior for developers * test(pagination): refactor unit test * refactor(pagination): refactor innternal value and warning message * refactor(pagination): remove unnecessary blur input * test(pagination): update test case to support value and max approach * refactor(pagination): use getter for toggle button state * test(pagination): refactor unit-test * chore(pagination): remove demo for testing * fix(pagination): tab on the input to set a value * fix(pagination): the input does not get disable state from the root * test(pagination): add test case interaction when page is over * test(pagination): fix typo * test(pagination): remove unexpected attribute in snapshot * refactor(pagination): cast type for text input * refactor(pagination): remove unused interface * chore(pagination): fix indent js doc incorrect * fix(pagination): remove warning when set correct type value * fix(pagiantion): convert prop toString in setter * fix(pagination): add missing feature blur to set page from the input * refactor(pagination): getter setter of max and page should be string * chore(release): publish [skip ci] - @refinitiv-ui/elements@5.9.1 * fix(halo-theme): fix backward compat with current import native-element path * fix(themes): ignore hover styles on mobile device (#129) Co-authored-by: Theeraphat-Sorasetsakul <86758473+Theeraphat-Sorasetsakul@users.noreply.github.com> * chore(release): publish [skip ci] - @refinitiv-ui/demo-block@5.1.5 - @refinitiv-ui/elemental-theme@5.4.1 - @refinitiv-ui/elements@5.10.0 - @refinitiv-ui/halo-theme@5.4.1 - @refinitiv-ui/i18n@5.2.5 - @refinitiv-ui/phrasebook@5.4.0 - @refinitiv-ui/solar-theme@5.6.1 - @refinitiv-ui/translate@5.2.5 * chore: add incremental to TypeScript compiler option for faster subsequent builds (#136) * chore: add `incremental` to TypeScript compiler option for faster subsequent builds * chore: update lock-file * ci: create `GitHub release` and curated CHANGELOG on release (#137) * chore(polyfills): remove exports and entrypoints (#141) * chore(polyfills): remove exports and entrypoints * chore(polyfills): change all.js to index.js Co-authored-by: Wasuwat Limsuparhat <86233706+wsuwt@users.noreply.github.com> * ci: use multiple stage pipeline for the test workflow (#140) * fix(pagination): handle case when user input number with string (#142) * fix: release script should not be publish to NPM (#144) * chore: add development mode to dev-server so that developers can see the warnings (#147) * chore: fix broken status badge (#154) * Chore/add framework integration samples (#153) * Chore/sample react app (#148) * docs: init react sample app * feat: add form handler * fix: change native styles import path * chore: change import path * test: revise test case * test: fix wrong expect value test case * test: change test case name * chore: fix intent and code styling * chore: change import path * chore: remove logo file * docs: init vanilla sample app (#152) * chore: sample angular app (#150) * docs: init angular sample app * chore: sample vue app Co-authored-by: Theeraphat-Sorasetsakul <86758473+Theeraphat-Sorasetsakul@users.noreply.github.com> Co-authored-by: Jidapa-Pai <91583604+Jidapa-Pai@users.noreply.github.com> Co-authored-by: Napat Bualoy <91940544+bualoy-napat@users.noreply.github.com> * fix(checkbox): `Enter` key should not check or uncheck checkbox * fix(radio-button): `Enter` key should not check or uncheck radio-button * test(checkbox): update `Enter` keypress test * test(radio-button): update `Enter` keypress test * chore(deps): bump postcss from 7.0.39 to 8.2.13 (#155) chore(deps): bump autoprefixer from 9.6.5 to 10.4.2 * feat: upgrade `lit` to 2.1.1 (#156) * fix(radio-button): add IE11 arrow keys navigation support (#158) * chore: revert web-server development mode (#162) * chore(release): publish [skip ci] - @refinitiv-ui/core@5.4.0 - @refinitiv-ui/demo-block@5.1.6 - @refinitiv-ui/elemental-theme@5.4.2 - @refinitiv-ui/elements@5.10.1 - @refinitiv-ui/halo-theme@5.4.2 - @refinitiv-ui/i18n@5.2.6 - @refinitiv-ui/phrasebook@5.4.1 - @refinitiv-ui/polyfills@5.2.0 - @refinitiv-ui/solar-theme@5.6.2 - @refinitiv-ui/test-helpers@5.1.2 - @refinitiv-ui/theme-compiler@5.0.7 - @refinitiv-ui/translate@5.3.0 * feat(tree): improve screen reader support (#102) * feat(list): improve screen reader * feat(list): add aria-multiselectable for screen reader * test(list): improve key control cases * test(tree): update snapshots for tree * feat(tree): add roles to tree and treee-item and add aria-expanded * fix: add more generic type to default role for extendibility * refactor: use setAttribute instead of overriding AOM properties * refactor: aria expanded and selected logics * feat: add aria level and setsize support * feat: remove asterick key support * feat: used aria-checked for multiple mode to indicate indeterminate state * chore: update lock file * refactor: simplify aria setting logics * feat: add generic type to treeitem defaulRole * fix: handles multiple mode changes * test(tree): update snapshots * refactor: reflect aria-selected according to selected state * refactor: move most of the aria setting logics to tree-item element * refactor: remove aria-setsize as it's no longer needed Co-authored-by: Jidapa-Pai <jidapa.nunkaew@refinitiv.com> Co-authored-by: Jidapa-Pai <91583604+Jidapa-Pai@users.noreply.github.com> * fix(tree-select): remove unnecessary x-scrollbar on default styles (#166) * fix(checkbox): wrong cursor style when hover the end of checkbox label (#165) fix(checkbox): wrong cursor style when hover the end of checkbox label * Include ef documentation into monorepo (#146) * docs: include EF documentation into monorepo Co-authored-by: Sarin Udompanish <sarin.udompanish@refinitiv.com> Co-authored-by: Napat Bualoy <napat.bualoy@lseg.com> Co-authored-by: Theeraphat Sorasetsakul <Theeraphat.Sorasetsakul@refinitiv.com> Co-authored-by: Jidapa-Pai <jidapa.nunkaew@refinitiv.com> Co-authored-by: wsuwt <wasuwat.limsuparhat@refinitiv.com> Co-authored-by: Wasuwat Limsuparhat <86233706+wsuwt@users.noreply.github.com> * docs: resize home page images appropriately (#169) * chore(release): publish [skip ci] (#171) - @refinitiv-ui/docs@5.0.1 - @refinitiv-ui/demo-block@5.1.7 - @refinitiv-ui/elements@5.11.0 - @refinitiv-ui/halo-theme@5.4.3 Co-authored-by: refinitiv-ui-dev <RefinitivUIDev@refinitiv.com> * feat(collapse): add accessibility support (#161) * Revert "feat(collapse): add accessibility support (#161)" (#179) This reverts commit 158f031. * chore(*): update package lock * refactor(*): move peers into peerDependencies (#178) * refactor(*): move peers into peerDependencies * chore(*): print npm version * chore(*): update package lock * fix(*): trial custom npm build * fix(*): build utils before core * chore(core): move utils to peerDependencies * chore(*): update release build commands * Add types versions (#183) * refactor(core): rename elf.ts to index.ts to ensure default importing refactor(utils): rename utils.ts to index.ts to ensure default importing refactor(core): simplify package exports to remove `lib` path support refactor(utils): simplify package exports to remove `lib` path support refactor(elements): simplify package exports to remove `lib` path support refactor(phrasebook): simplify package exports to remove `lib` path support * fix(*): be flexible with types versions Co-authored-by: Tremayne Christ <tremayne.christ@refinitiv.com> Co-authored-by: Aleksejs <81616437+goremikins@users.noreply.github.com> * chore(*): use node 16.x in prerelease script * chore(*): test on prerelease branch * test(core): replace elf.js with index.js Co-authored-by: Sakchai Homhual <Sakchai.Homhual@refinitiv.com> Co-authored-by: Theeraphat-Sorasetsakul <86758473+Theeraphat-Sorasetsakul@users.noreply.github.com> Co-authored-by: Theeraphat Sorasetsakul <Theeraphat.Sorasetsakul@refinitiv.com> Co-authored-by: Sakchai Homhual <87511654+Sakchai-Refinitiv@users.noreply.github.com> Co-authored-by: refinitiv-ui-dev <RefinitivUIDev@refinitiv.com> Co-authored-by: Domrongpon Tanpaibul <domrongpon.tanpaibul@refinitiv.com> Co-authored-by: dtanp <81604092+dtanp-rft@users.noreply.github.com> Co-authored-by: Sarin-Udompanish <86759822+Sarin-Udompanish@users.noreply.github.com> Co-authored-by: Wasuwat Limsuparhat <86233706+wsuwt@users.noreply.github.com> Co-authored-by: Jidapa-Pai <91583604+Jidapa-Pai@users.noreply.github.com> Co-authored-by: Napat Bualoy <91940544+bualoy-napat@users.noreply.github.com> Co-authored-by: wsuwt <wasuwat.limsuparhat@refinitiv.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jidapa-Pai <jidapa.nunkaew@refinitiv.com> Co-authored-by: Sarin Udompanish <sarin.udompanish@refinitiv.com> Co-authored-by: Napat Bualoy <napat.bualoy@lseg.com> Co-authored-by: Aleksejs <81616437+goremikins@users.noreply.github.com>
Collaborator
|
@Sakchai-Refinitiv Please recreate #161 back again and we can put in scope of next sprint for deeper review. |
7 tasks
Collaborator
|
I have created a new one #189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #161
@Sakchai-Refinitiv this should be reviewed properly by members of the team with deeper accessibility knowledge.