Skip to content

chore: scrub private/personal references from the public repo#125

Merged
yilu331 merged 3 commits into
mainfrom
chore/scrub-private-repo-refs
Jun 4, 2026
Merged

chore: scrub private/personal references from the public repo#125
yilu331 merged 3 commits into
mainfrom
chore/scrub-private-repo-refs

Conversation

@yilu331
Copy link
Copy Markdown
Collaborator

@yilu331 yilu331 commented Jun 4, 2026

What

This is the public/open-source repo, so it must not point readers at content only visible in the private reflexio-enterprise repo, nor leak personal/local paths. All changes are comment/docstring/doc-only — no behavior change.

Private reflexio-enterprise references

  • reflexio-enterprise#59 private-issue citations dropped across the pending-request-queue ("R2") code + tests (kept the R2 label).
  • bootstrap_config.py — removed the dead See docs_for_coding_agent/… pointer (private-only doc).
  • setup_cmd.py (openai-codex --help) — stopped pointing at the private reflexio_ext/scripts/start_with_codex_proxy.sh.
  • .claude/rules/pythonic-code.md — genericized a reflexio_ext/scripts/ path example.

Open-core extension-seam mentions (genericized)

  • env_loader.py, lib/_storage_labels.py, server/README.md — reworded reflexio_ext mentions to describe the extension contract without naming the private package/file path.

gdpval benchmark — scrubbed in place (kept public)

benchmark/gdpval/ stays public (needed for marketing data/claims). Made it public-appropriate: replaced personal /Users/<user>/… paths with generic/$ENV paths, dropped the private reflexio-gdpval-bench repo name, used public reflexio.cli instead of reflexio_ext.cli, removed a personal ~/.claude/plans/ reference. Framework names (OpenSpace/Hermes) kept — part of the published RESULTS.md narrative; code resolves their paths via env vars.

Verification

  • import reflexio OK; ruff clean; py_compile OK on changed gdpval modules.
  • git grep for reflexio-enterprise#59, /Users/, reflexio-gdpval-bench, gdpval reflexio_ext → clean.

This is the open-source repo, so it must not point readers at content only
visible in the private reflexio-enterprise repo. Remove such references
(comment/docstring-only — no behavior change):

- Drop 7 `reflexio-enterprise#59` private-issue citations across the
  pending-request-queue ("R2") code + tests; keep the internal "R2" label.
- bootstrap_config.py: remove the dead "See docs_for_coding_agent/…" pointer
  (that doc lives only in the private repo).
- setup_cmd.py (openai-codex `--help`): stop instructing users to run the
  private `reflexio_ext/scripts/start_with_codex_proxy.sh`; describe the proxy
  picking up tokens automatically instead.
- pythonic-code rule: genericize the `reflexio_ext/scripts/` path example.

Left intact: architecture notes that legitimately name the `reflexio_ext`
extension package as the open-core seam (env_loader, _storage_labels,
server/README) — those document the contract, not unreachable content.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes stale references to enterprise extension identifiers and outdated documentation throughout the codebase. Changes include correcting path comments, updating environment configuration descriptions, simplifying R2-related issue references, and generalizing authentication and storage documentation to avoid explicit enterprise extension mentions.

Changes

Documentation and reference cleanup

Layer / File(s) Summary
CLI and environment configuration documentation
.claude/rules/pythonic-code.md, reflexio/cli/bootstrap_config.py, reflexio/cli/commands/setup_cmd.py, reflexio/cli/env_loader.py
Path comment updated to reflect correct directory mapping, external documentation pointer removed from bootstrap config, setup command instructions rewritten to describe automatic token pickup instead of legacy script invocation, and environment module selection generalized to describe both OS package and downstream build scenarios.
Core library and server documentation
reflexio/lib/_storage_labels.py, reflexio/server/README.md
Storage type matching docstring clarified regarding enterprise extension dependency, and authentication pattern description generalized to remove explicit reference to enterprise extension module path.
Implementation comments in generation and operation services
reflexio/server/services/base_generation_service.py, reflexio/server/services/operation_state_utils.py, reflexio/server/services/storage/storage_base/_operations.py
Inline comments and docstrings simplified by removing enterprise issue reference suffix from R2 behavior descriptions in serialization, lock management, and bookmark semantics across three service files.
Test documentation cleanup
tests/e2e_tests/test_concurrent_playbook_extraction.py, tests/server/services/storage/test_storage_contract_operations.py, tests/server/services/test_base_generation_service.py, tests/server/services/test_operation_state_utils.py
Test module and section headers simplified by removing enterprise issue reference from R2-related scenario labels and pending request queue descriptions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • ReflexioAI/reflexio#113: Both PRs modify reflexio/server/README.md authentication pattern section to generalize descriptions and reduce stale enterprise-specific references.
  • ReflexioAI/reflexio#57: This PR further refines test documentation in test_concurrent_playbook_extraction.py by removing the enterprise issue reference while maintaining the R2 scenario label introduced by the earlier PR.

Poem

🐰 References hop away to greener docs so clear,
Enterprise ghosts fade as generic prose draws near,
R2's story stays, but the issue tag takes flight,
Cleaner comments bloom—reflexio shines bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: scrub private/personal references from the public repo' clearly and accurately summarizes the main change: removing references to private repositories and resources from the public codebase.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/scrub-private-repo-refs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

yilu331 added 2 commits June 4, 2026 23:06
…chmark public)

gdpval stays in the public repo (needed for marketing data/claims), so make it
public-appropriate in place:
- replace personal absolute paths (/Users/<user>/...) with generic/env-var paths
- drop the private 'reflexio-gdpval-bench' repo name from setup commands/comments
- use the public 'reflexio.cli' instead of 'reflexio_ext.cli' in the run recipe
- remove a personal ~/.claude/plans/ scratch-file reference
Framework names (OpenSpace/Hermes) are kept — they're part of the published
benchmark narrative. Code already resolves their paths via env vars.
@yilu331 yilu331 changed the title chore: scrub private reflexio-enterprise references from the public repo chore: scrub private/personal references from the public repo Jun 4, 2026
@yilu331 yilu331 merged commit 31f152a into main Jun 4, 2026
1 check passed
@yilu331 yilu331 deleted the chore/scrub-private-repo-refs branch June 4, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant