Update integration test data repository to ReforgeHQ #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change submodule URL from prefab-cloud/prefab-cloud-integration-test-data - to ReforgeHQ/integration-test-data - Use SSH URL for better access control 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Adds reforge.current-time as an alternative to prefab.current-time for criterion evaluation in ConfigRuleEvaluator. Both keys now return the current system timestamp in milliseconds when used in configuration rules. Changes: - Add REFORGE_CURRENT_TIME_KEY constant for "reforge.current-time" - Update getPropFromContext() to check both prefab and reforge current-time keys - Add comprehensive test case validating both positive and negative scenarios This maintains backward compatibility while supporting the new reforge branding. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
jkebinger
force-pushed
the
update-integration-test-data-repo
branch
from
3732171 to
34e2974
Compare
Replace prefab_api_url with reforge_api_url in IntegrationTestClientOverrides to support the updated test data format. This fixes parsing errors in integration tests that were using the new field name. - Update IntegrationTestClientOverrides to accept reforge_api_url instead of prefab_api_url - Update BaseIntegrationTestCaseDescriptor to use getReforgeApiUrl() - Update integration test data submodule to latest version 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
reforge.current-timealongside existingprefab.current-timefunctionalityChanges Made
Integration Test Data Repository Update
.gitmodulesto point togit@github.com:ReforgeHQ/integration-test-data.gitCurrent Time Key Support
REFORGE_CURRENT_TIME_KEYconstant for"reforge.current-time"in ConfigRuleEvaluatorprefab.current-timeandreforge.current-timeBackward Compatibility
✅ Fully backward compatible - no breaking changes:
prefab.current-timecontinues to work exactly as beforereforge.current-timenow works identically toprefab.current-timeTest Plan
testReforgeCurrentTimeKey()validates both positive and negative scenariosprefab.current-timeandreforge.current-timework identically in criterion evaluationThis ensures seamless transition to ReforgeHQ branding while maintaining full compatibility with existing Prefab configurations.
🤖 Generated with Claude Code