fix(app): stabilize flutter integration tests on windows desktop#38
Merged
Refraggerator merged 1 commit intomainfrom Mar 13, 2026
Merged
fix(app): stabilize flutter integration tests on windows desktop#38Refraggerator merged 1 commit intomainfrom
Refraggerator merged 1 commit intomainfrom
Conversation
Owner
Refraggerator
commented
Mar 13, 2026
Refraggerator
commented
- Updated '1.7 Delete a server' to use kSecondaryButton instead of longPress for desktop compatibility.
- Added explicit Duration timeouts to pumpAndSettle calls to improve reliability on Windows.
- Enhanced debug logging for test isolation and troubleshooting.
There was a problem hiding this comment.
Pull request overview
Stabilizes Flutter desktop (Windows) integration tests by adjusting interactions and adding additional settling/logging, but also includes an unrelated AppService token change that can break local Docker setups.
Changes:
- Update the “1.7 Delete a server” flow to open the context menu via secondary click (
kSecondaryButton) instead oflongPressfor desktop compatibility. - Add extra debug prints and modify a few test-client variable names in the visual integration suite.
- Change Synapse AppService registration tokens in
server/appservice/registration.yaml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| server/appservice/registration.yaml | Rotates as_token/hs_token values used by Synapse + AS auth (currently mismatches .env.example). |
| app/integration_test/visual_test.dart | Adjusts a desktop interaction (secondary click), adds additional pumpAndSettle(Duration(...)) calls, and renames some test variables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+8
to
+9
| as_token: "D872ECE1763334FB6F748A0B1F7EBF7EAB4DF5D4BE9EE690FF52A832FE58FF6B" | ||
| hs_token: "597E4D43B64130D3FD419607E0137788E0D7E41AF0E8A9A1383F5D0924A02FD9" |
Comment on lines
+497
to
+505
| await tester.pumpAndSettle(const Duration(seconds: 2)); | ||
| print('--- 1.7 Tap Remove Server ---'); | ||
| await tester.tap(find.text('Remove Server')); | ||
| await tester.pumpAndSettle(); | ||
| await tester.pumpAndSettle(const Duration(seconds: 2)); | ||
|
|
||
| print('--- 1.7 Confirm Remove Dialog ---'); | ||
| await tester.tap(find.descendant( | ||
| of: find.byType(AlertDialog), matching: find.text('Remove'))); | ||
| await tester.pumpAndSettle(); | ||
| await tester.pumpAndSettle(const Duration(seconds: 2)); |
Comment on lines
+1669
to
+1670
| final clientaUi = await _freshClient('VT_9_8_A_ui'); | ||
| await pumpAppWithServer(tester, clientaUi); |
Comment on lines
+497
to
+500
| await tester.pumpAndSettle(const Duration(seconds: 2)); | ||
| print('--- 1.7 Tap Remove Server ---'); | ||
| await tester.tap(find.text('Remove Server')); | ||
| await tester.pumpAndSettle(); | ||
| await tester.pumpAndSettle(const Duration(seconds: 2)); |
- Updated '1.7 Delete a server' to use kSecondaryButton instead of longPress for desktop compatibility. - Added explicit Duration timeouts to pumpAndSettle calls to improve reliability on Windows. - Enhanced debug logging for test isolation and troubleshooting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.