Values Struct Equality Fix #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values2 passes, Values3 and Values4 fail all but the first generic argument equality.
This is invalid as it never would actually deserialize to two types at once - the previous equality logic had this test erroneously passing.
Collaborator
Author
|
The test I've removed in cd68610 was flawed - the original While I could have changed the expected data to only include a URI value (as that was the type of data that was deserialized), it would no longer fit with the spirit of the other tests in that file. It wouldn't really be any more of a test than the tests added specifically for |
Owner
|
Thank you. |
RehanSaeed
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a subtle bug in the equality checking of the
Valuesstructs that didn't properly handle mixed types. WhileValues2did properly handle mixed types, it didn't properly handle only one of the types having data.After a bit of studying the code, it really can be simplified down to comparing the internal
OneOrMany. I do add one additional check prior to that as a shortcut for empty data.