refactor: reorganize JSX element checks and remove unneeded functions

packages/core/docs/README.md

@@ -128,7 +128,6 @@
 - [isInitializedFromReact](functions/isInitializedFromReact.md)
 - [isJsxLike](functions/isJsxLike.md)
 - [isJsxText](functions/isJsxText.md)
-- [isKeyedElement](functions/isKeyedElement.md)
 - [isNeverType](functions/isNeverType.md)
 - [isNullishType](functions/isNullishType.md)
 - [isNumberType](functions/isNumberType.md)

packages/core/docs/functions/isFragmentElement.md

@@ -6,46 +6,18 @@
 
 # Function: isFragmentElement()
 
-## Call Signature
+> **isFragmentElement**(`context`, `node`): `node is JSXElement`
 
-> **isFragmentElement**(`context`, `node`, `allowJSXFragment?`): `node is JSXElement`
+## Parameters
 
-### Parameters
-
-#### context
+### context
 
 `RuleContext`
 
-#### node
-
-`undefined` | `null` | `Node`
+### node
 
-#### allowJSXFragment?
+`Node`
 
-`false`
-
-### Returns
+## Returns
 
 `node is JSXElement`
-
-## Call Signature
-
-> **isFragmentElement**(`context`, `node`, `allowJSXFragment?`): node is JSXElement \| JSXFragment
-
-### Parameters
-
-#### context
-
-`RuleContext`
-
-#### node
-
-`undefined` | `null` | `Node`
-
-#### allowJSXFragment?
-
-`true`
-
-### Returns
-
-node is JSXElement \| JSXFragment

packages/core/src/jsx/index.ts

@@ -3,8 +3,8 @@ export * from "./jsx-attribute-name";
 export * from "./jsx-attribute-value";
 export * from "./jsx-detection";
 export * from "./jsx-detection-hint";
+export * from "./jsx-element-is";
 export * from "./jsx-element-type";
 export * from "./jsx-has";
 export * from "./jsx-hierarchy";
-export * from "./jsx-is";
 export * from "./jsx-stringify";

packages/core/src/jsx/jsx-element-is.ts

@@ -0,0 +1,17 @@
+import type { RuleContext } from "@eslint-react/kit";
+import type { TSESTree } from "@typescript-eslint/types";
+import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
+import { getElementType } from "./jsx-element-type";
+
+export function isHostElement(context: RuleContext, node: TSESTree.Node) {
+  return node.type === T.JSXElement
+    && node.openingElement.name.type === T.JSXIdentifier
+    && /^[a-z]/u.test(node.openingElement.name.name);
+}
+
+export function isFragmentElement(context: RuleContext, node: TSESTree.Node): node is TSESTree.JSXElement {
+  if (node.type !== T.JSXElement) return false;
+  return getElementType(context, node)
+    .split(".")
+    .at(-1) === "Fragment";
+}

packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.ts

@@ -105,7 +105,7 @@ function checkNode(
 ) {
   const initialScope = context.sourceCode.getScope(node);
   // return if the fragment is keyed (e.g. <Fragment key={key}>)
-  if (ER.isKeyedElement(context, node, initialScope)) {
+  if (node.type === T.JSXElement && ER.hasAttribute(context, "key", node.openingElement.attributes, initialScope)) {
     return;
   }
   // report if the fragment is placed inside a host component (e.g. <div><></></div>)