Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Aug 21, 2025

  • Restructure scripts directory: move lib/ to effects/ and utils/
  • Move ignores.ts and version.ts to effects/ directory
  • Rename glob.ts location from lib/ to utils/
  • Update script imports to reflect new directory structure
  • Update package dependencies across all packages
  • Regenerate pnpm-lock.yaml with updated dependency tree

This change improves the scripts organization by separating effects (side-effect operations) from utilities (pure functions).

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

- Restructure scripts directory: move lib/ to effects/ and utils/
- Move ignores.ts and version.ts to effects/ directory
- Rename glob.ts location from lib/ to utils/
- Update script imports to reflect new directory structure
- Update package dependencies across all packages
- Regenerate pnpm-lock.yaml with updated dependency tree

This change improves the scripts organization by separating
effects (side-effect operations) from utilities (pure functions).
@socket-security
Copy link

socket-security bot commented Aug 21, 2025

@Rel1cx Rel1cx requested a review from Copilot August 21, 2025 22:24

This comment was marked as outdated.

@vercel
Copy link

vercel bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Ready Ready Preview Comment Aug 21, 2025 10:36pm

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: REL1CX <dokimondex@gmail.com>
@Rel1cx Rel1cx requested a review from Copilot August 21, 2025 22:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the scripts directory organization and migrates from vanilla Node.js code to the Effect.js framework for improved functional programming patterns. The refactor separates side-effect operations (moved to effects/) from pure utility functions (moved to utils/), while also updating package dependencies across the project.

  • Reorganizes scripts directory structure: moving files from lib/ to effects/ and utils/ directories
  • Migrates scripts to use Effect.js for functional programming with proper error handling and composable effects
  • Updates package dependencies including Effect.js, Next.js, Vite, and various ESLint plugins

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/verify-lockfile.ts Migrates from vanilla Node.js to Effect.js for git diff command execution
scripts/update-version.ts Refactors to use Effect.js with new imports from reorganized directory structure
scripts/update-website.ts Updates import path from lib/glob to utils/glob
scripts/effects/version.ts New Effect.js implementation for reading and processing VERSION file
scripts/effects/ignores.ts New Effect.js implementation for reading and processing .gitignore file
package.json Adds Effect.js dependencies and updates @swc/core
Various example packages Updates Vite, Next.js, and other dependency versions
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Rel1cx and others added 2 commits August 22, 2025 06:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: REL1CX <dokimondex@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: REL1CX <dokimondex@gmail.com>
@Rel1cx Rel1cx marked this pull request as ready for review August 21, 2025 22:32
@Rel1cx Rel1cx merged commit 3d5f92d into main Aug 21, 2025
9 of 10 checks passed
@Rel1cx Rel1cx deleted the refactor/scripts-structure-and-version-update branch August 21, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants