Fix no-leaked-event-listener false positive when using React NativeBackHandler, closes #1323
#1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `BackHandler`, closes #1323
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a false positive in the no-leaked-event-listener rule when using React Native's BackHandler.addEventListener API. The fix involves extracting common logic from isInitializedFromReact into a new generic utility function isInitializedFromSource, which can check if an identifier is initialized from any source package.
- Refactored source-checking logic into a reusable
isInitializedFromSourceutility function - Added React Native detection to skip false positives in
no-leaked-event-listenerrule - Updated public API documentation for
isInitializedFromReact
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-event-listener.ts | Added check to skip React Native addEventListener calls to prevent false positives |
| packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-event-listener.spec.ts | Added test case verifying React Native BackHandler.addEventListener is allowed |
| packages/core/src/utils/is-from-source.ts | New generic utility function to check if an identifier is initialized from any source package |
| packages/core/src/utils/is-from-react.ts | Refactored to use the new isInitializedFromSource utility, maintaining the React-specific name check |
| packages/core/src/utils/index.ts | Exported the new isInitializedFromSource utility |
| packages/core/docs/functions/isInitializedFromReact.md | Added public API documentation for isInitializedFromReact function |
| packages/core/docs/README.md | Added reference to isInitializedFromReact documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-event-listener.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: REL1CX <rel1cx@proton.me>
…ed-event-listener.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: REL1CX <rel1cx@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information