-
-
Notifications
You must be signed in to change notification settings - Fork 32
Minor docs improvements #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor docs improvements #1339
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5df486c to
03e7627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to improve documentation formatting across the codebase by standardizing JSDoc comment format. However, the implementation has introduced systematic formatting errors throughout.
Key Changes:
- Attempted to standardize JSDoc
@paramtag format by removing hyphens between parameter names and descriptions - Added JSDoc comments to previously undocumented functions in
packages/core/src/utils/is-react-api.ts - Updated generated documentation files to reflect source changes
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 62 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/utilities/eff/src/index.ts | Updated JSDoc parameter format for multiple utility functions (introduces formatting errors) |
| packages/utilities/ast/src/function-init-path.ts | Updated JSDoc parameter format for function initialization path utilities (introduces formatting errors) |
| packages/utilities/ast/src/expression-is.ts | Updated JSDoc parameter format for expression checking function (introduces formatting errors) |
| packages/utilities/ast/src/expression-base.ts | Updated JSDoc parameter format for expression unwrapping function (introduces formatting errors) |
| packages/plugins/eslint-plugin-react-x/src/rules/no-string-refs.ts | Updated JSDoc parameter format for helper functions (introduces formatting errors) |
| packages/plugins/eslint-plugin-react-x/src/rules/no-forward-ref.ts | Updated JSDoc parameter format for helper functions (introduces formatting errors) |
| packages/plugins/eslint-plugin-react-dom/src/utils/create-jsx-element-resolver.ts | Updated JSDoc parameter format for resolver functions (introduces formatting errors) |
| packages/plugins/eslint-plugin-react-dom/src/rules/no-unsafe-target-blank.ts | Updated JSDoc parameter format for validation functions (introduces formatting errors) |
| packages/plugins/eslint-plugin-react-dom/src/rules/no-unknown-property.ts | Updated JSDoc parameter format for multiple helper functions (introduces formatting errors) |
| packages/core/src/utils/is-react-api.ts | Added documentation for React API checking functions and section comments |
| packages/core/src/jsx/jsx-stringify.ts | Updated JSDoc parameter format (introduces formatting errors) |
| packages/core/src/jsx/jsx-hierarchy.ts | Updated JSDoc parameter format (introduces formatting errors) |
| packages/core/src/jsx/jsx-element-type.ts | Updated JSDoc parameter format (introduces formatting errors) |
| packages/core/src/jsx/jsx-element-is.ts | Updated JSDoc parameter format (introduces formatting errors) |
| packages/core/src/component/component-name.ts | Updated JSDoc parameter format (introduces formatting errors) |
| packages/core/src/component/component-definition.ts | Updated JSDoc parameter format and introduces duplicate @param entries (introduces formatting errors) |
| packages/core/src/component/component-collector-legacy.ts | Updated JSDoc parameter format and introduces duplicate @param entries (introduces formatting errors) |
| packages/utilities/eff/docs/* | Generated documentation files with stray asterisks from source formatting errors |
| packages/core/docs/* | Generated documentation files reflecting source changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information