fix: case-insensitive validation for custom field options#72
Merged
ManukMinasyan merged 1 commit into3.xfrom Jan 29, 2026
Merged
fix: case-insensitive validation for custom field options#72ManukMinasyan merged 1 commit into3.xfrom
ManukMinasyan merged 1 commit into3.xfrom
Conversation
Replace Filament's distinct() with custom closure rule using Collection duplicates() for case-insensitive comparison. Prevents database unique constraint violations when adding options like "AB" and "ab".
There was a problem hiding this comment.
Pull request overview
This PR enhances validation for custom field options by implementing case-insensitive duplicate detection. The change prevents database unique constraint violations that would occur when users attempt to create options that differ only in case (e.g., "Active" and "active").
Changes:
- Replaced Filament's built-in
distinct()validation with a custom closure that performs case-insensitive comparison using Laravel Collection'sduplicates()method - Added test coverage to verify case-insensitive validation works correctly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Filament/Management/Schemas/FieldForm.php |
Replaced distinct() with custom validation closure that uses mb_strtolower() and Collection duplicates() for case-insensitive duplicate detection |
tests/Feature/Admin/Pages/CustomFieldsValidationTest.php |
Added test case to verify option names are validated as unique in a case-insensitive manner |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Filament's distinct() with custom closure rule using Collection duplicates() for case-insensitive comparison. Prevents database unique constraint violations when adding options like "AB" and "ab".