create phantom task for GC threads (#53815) & fix ordering in jl_safe_printf#141
Merged
d-netto merged 1 commit intov1.10.2+RAIfrom Mar 28, 2024
Merged
Conversation
github-actions
bot
added
port-to-v1.10
port-to-v1.12
kpamnany
reviewed
Mar 28, 2024
kpamnany
left a comment
kpamnany
left a comment
There was a problem hiding this comment.
You haven't added the assert in jl_init_root_task that you have upstream?
Best to just cherry-pick an upstream commit into our build; it makes it easier to track RAI-specific changes to our build vs. backports.
kpamnany
removed
port-to-v1.10
port-to-v1.12
A common idiom used throughout the codebase is to get a pointer to thread-local-state through `jl_current_task->ptls`. Create a phantom task for GC threads so that we can make use of this idiom when running in the GC threads as well. Idea originally suggested by @vchuravy, bugs are mine.
d-netto
force-pushed
the
dcn-bugfix-for-safe-crash-log-file
branch
from
031dc83 to
14d41b7
Compare
Author
Added in the last commit. |
nickrobinson251
pushed a commit
that referenced
this pull request
Feb 26, 2025
A common idiom used throughout the codebase is to get a pointer to thread-local-state through `jl_current_task->ptls`. Create a phantom task for GC threads so that we can make use of this idiom when running in the GC threads as well. Idea originally suggested by @vchuravy, bugs are mine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
A common idiom used throughout the codebase is to get a pointer to thread-local-state through
jl_current_task->ptls.Create a phantom task for GC threads so that we can make use of this idiom when running in the GC threads as well.
Idea originally suggested by @vchuravy, bugs are mine.
Checklist
Requirements for merging:
port-to-*labels that don't apply.