Support v2 "async" transactions returning multipart Arrow responses #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 1: WIP basic GET/PUT calls for the v2 API.
NHDaly
commented
Mar 29, 2022
vilterp
reviewed
Mar 29, 2022
src/api.jl
Outdated
| # todo: when we have async transactions, add a variation that dispatches and | ||
| # waits .. consider creating two entry points for readonly and readwrite. | ||
|
|
||
| function exec_v2(ctx::Context, database::AbstractString, engine::AbstractString, source; inputs = nothing, readonly = false, kw...) |
There was a problem hiding this comment.
👍 but actually: i think this package is so early days, i'd rather just call this one exec, and rename the v1 exec to something else, maybe RAI.V1.exec or RAI.exec_v1!
(Or actually, naming this one exec_async() and then having one more wrapper called exec() that does the polling)
There was a problem hiding this comment.
For now i'm going to rename this to exec_async(), based on the above, i think.
* Add support for v1_inputs to v2-style exec :) * Adjust to latest /problems endpoint implementation from frontend * Better comment + version patch on parse_multipart_form
```bash
$ julia --proj examples/exec_async.jl "nhd-test-1" "nhd-s" "def x = 1 def x = x+1 def output = x"
Transaction is created...
JSON3.Object{Vector{UInt8}, Vector{UInt64}} with 2 entries:
:id => "c616a8ae-3be2-0d51-fb0e-b7f862bc367d"
:state => "CREATED"
```
vilterp
approved these changes
Mar 31, 2022
|
Thanks Pete! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.